Skip to content

Add duplicateAndRenameSharedEvents customization to support event shapes shared with multiple evenstreams #6031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 18, 2025

Conversation

alextwoods
Copy link
Contributor

Add processor to detect shared events + customization to duplicate.

Motivation and Context

When an event shape is shared between multiple eventstreams, it causes SDK generation/compilation failures. The top level shape POJO implements the event stream interface for each stream and the return type of the sdkEventType method conflicts.

Modifications

This PR adds two things:

  1. A new customization config (duplicateAndRenameSharedEvents)
  2. A new processor (EventStreamSharedEventProcessor) which applies the customization and raises helpful error messages if shared events are detected.

Testing

Added new unit tests to cover processor/config. Manual testing of internal service model that raised this issue.

Screenshots (if appropriate)

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)

Checklist

  • [ x] I have read the CONTRIBUTING document
  • [ x] Local run of mvn install succeeds
  • [ x] My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • [ x] I have added tests to cover my changes
  • [ x] All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [x ] I confirm that this pull request can be released under the Apache 2 license

Copy link

@alextwoods alextwoods changed the title Add processor to detect shared events + customization to duplicate. Add duplicateAndRenameSharedEvents customization to support event shapes shared with multiple evenstreams Aug 14, 2025
@alextwoods alextwoods marked this pull request as ready for review August 14, 2025 18:13
@alextwoods alextwoods requested a review from a team as a code owner August 14, 2025 18:13
Copy link

@alextwoods alextwoods added this pull request to the merge queue Aug 18, 2025
Merged via the queue into master with commit 5d2b640 Aug 18, 2025
38 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants